Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support @readonly phpdoc #1295

Merged
merged 10 commits into from
May 18, 2022
Merged

Support @readonly phpdoc #1295

merged 10 commits into from
May 18, 2022

Commits on May 18, 2022

  1. Support @readonly phpdoc

    @herndlm
    herndlm committed May 18, 2022
    Configuration menu
    Copy the full SHA
    e5bffa8 View commit details
    Browse the repository at this point in the history

  2. Remove phpdoc readonly support from MissingReadOnlyPropertyAssignRule

    @herndlm
    herndlm committed May 18, 2022
    Configuration menu
    Copy the full SHA
    7f68c7b View commit details
    Browse the repository at this point in the history

  3. Remove test that doesn't add much value

    @herndlm
    herndlm committed May 18, 2022
    Configuration menu
    Copy the full SHA
    a0f43eb View commit details
    Browse the repository at this point in the history

  4. UninitializedPropertyRule is now dead too..

    @herndlm
    herndlm committed May 18, 2022
    Configuration menu
    Copy the full SHA
    a1541a2 View commit details
    Browse the repository at this point in the history

  5. Separate rules, bring back UninitializedPropertyRule test case, move … 

    …rules to bleeding edge, use consistent naming for methods and props
    @herndlm
    herndlm committed May 18, 2022
    Configuration menu
    Copy the full SHA
    82247bf View commit details
    Browse the repository at this point in the history

  6. Match resolveHasConsistentConstructor

    @herndlm
    herndlm committed May 18, 2022
    Configuration menu
    Copy the full SHA
    35d4fec View commit details
    Browse the repository at this point in the history

  7. Cleanup ClassPropertyNode constructor

    @herndlm
    herndlm committed May 18, 2022
    Configuration menu
    Copy the full SHA
    668af30 View commit details
    Browse the repository at this point in the history

  8. Cleanup MissingReadOnlyByPhpDocPropertyAssignRule DI config

    @herndlm
    herndlm committed May 18, 2022
    Configuration menu
    Copy the full SHA
    2e2dde4 View commit details
    Browse the repository at this point in the history

  9. Use @readonly in the error messages so that there's a slight differ… 

    …ence to the non-phpdoc rules
    @herndlm
    herndlm committed May 18, 2022
    Configuration menu
    Copy the full SHA
    5f1674e View commit details
    Browse the repository at this point in the history

  10. Get rid of PhpPropertyReflection default constructor arg too

    @herndlm
    herndlm committed May 18, 2022
    Configuration menu
    Copy the full SHA
    b7d54a1 View commit details
    Browse the repository at this point in the history