Improve wording of the NonexistentOffset, BooleanAndConstantConditionRule and BooleanOrConstantConditionRule

[VincentLanglet]

Related to phpstan/phpstan#8187 (comment)

I feel like

Offset 'c' does not exist on array{c?: int}.

is confusing and

Offset 'c' might not exist on array{c?: int}.

is better.

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

We can't do this because it'd break existing baselines. We can do this only with a new bleedingEdge toggle.

A similar thing could be fixed in BooleanAndConstantConditionRule and BooleanOrConstantConditionRule where the message still uses && and || even for logical and and or operators.

[herndlm]

new bleeding edge toggle kind of means that it will get into the next major automatically, right?
sounds like a good solution then, otherwise it would need to be remembered / noted down :)

[ondrejmirtes]

Exactly, and no rebase nightmare either.

[VincentLanglet]

Yeah, I'll update the PR

[VincentLanglet]

We can't do this because it'd break existing baselines. We can do this only with a new bleedingEdge toggle.

Done

A similar thing could be fixed in BooleanAndConstantConditionRule and BooleanOrConstantConditionRule where the message still uses && and || even for logical and and or operators.

Done

[ondrejmirtes]

Thank you.