Do not truncate offset key #3437
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 2.0.x. PHPStan 2.0 is not going to be released for months. If your code is relevant on 1.12.x and you want it to be released sooner, please rebase your pull request and change its target to 1.12.x. |
When you have an array with long key names, it becomes hard / impossible to see which one errors. I think it would be better to be precise here.
ruudk
force-pushed
the
precise-offset-key
branch
from
873de9e
to
05302bf
Compare
|
Maybe it would be an idea to make this decision available in the configuration, because every project is different and it might be useful sometimes and sometimes not? 🤔 |
|
This is just abou an error tip so it should always be precise and informative. Thank you! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have an array with long key names, it becomes hard / impossible to see which one errors:
I think it would be better to be precise here.
@ondrejmirtes curious if you agree 😊