Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use drivewsid and zone that work for app folders #417

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krwenholz
Copy link

Appears to be backwards compatible with everything.

Breaking change

I don't think anything is broken here. I'm developing this on an iPad without a proper Mac to run thorough tests though, so some help kicking the tires on writes in particular.

Proposed change

I wasn't seeing any output for contents of app created folders in iCloud Drive. In particular, I was trying to download files synced by iA Writer. Files created in folders I, the user, created showed up fine. Looking at the data diffs, it seems the docwsid is different from the drivewsid in that the drivewsid always works but docwsid only works for user created folders. This may also be due to the zone parameter. I couldn't make heads nor tails of Apple's developer docs to confirm this though :/

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New service (thank you!)
  • New feature (which adds functionality to an existing service)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation or code sample

Example of code:

Once authenticated just try listing files in a folder created by an app and, optionally, downloading them.

api = PyiCloudService(os.environ["ICLOUD_USER"], os.environ["ICLOUD_PASS"])
file_names = api.drive["Some Folder"].dir()

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works. (Would love help on this! New to testing in Python and not seeing tests that cover this functionality.)

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated to README

Appears to be backwards compatible with everything.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant