Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add the http api and new configuration members for ballast object #29121

Merged
merged 13 commits into from
Oct 26, 2021

Conversation

hnes
Copy link
Contributor

@hnes hnes commented Oct 26, 2021

What problem does this PR solve?

Problem Summary:

Try to reduce the GC frequency on some occasions.

What is changed and how it works?

What's Changed:

Add a ballast object.

How it Works:

Here are some articles and documentation.

SetGCPercent

Go memory ballast: How I learned to stop worrying and love the heap

proposal: runtime: add a mechanism for specifying a minimum target heap size

Performance Benefits

In a typical OLTP scenario, 2GB ballast could bring tps ~+16.8%, latency ~-13.5%, cpu ~-16.3%.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
# get current size of the ballast object
curl -v 127.0.0.1:10080/debug/ballast-object-sz
# reset the size of the ballast object (2GB in this example)
curl -v -d "2147483648" -X POST 127.0.0.1:10080/debug/ballast-object-sz

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Add the http api and new configuration members for the ballast object.

hnes and others added 4 commits October 25, 2021 18:10
Signed-off-by: Sen Han <00hnes@gmail.com>
A better error description when the input ballast-object-sz from the POST body is negative.

Co-authored-by: Lei Zhao <zlwgx1023@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 26, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • coocood
  • youjiali1995

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2021
server/http_status.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 26, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 26, 2021
@coocood
Copy link
Member

coocood commented Oct 26, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: b31be95

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 26, 2021
@ti-chi-bot ti-chi-bot merged commit 1c1cb9d into pingcap:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants