Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert sarama v.1.32.0 to v1.29.0 #5101

Closed
3AceShowHand opened this issue Apr 2, 2022 · 0 comments · Fixed by #5086
Closed

revert sarama v.1.32.0 to v1.29.0 #5101

3AceShowHand opened this issue Apr 2, 2022 · 0 comments · Fixed by #5086
Assignees
@3AceShowHand
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@3AceShowHand
Copy link
Contributor

3AceShowHand commented Apr 2, 2022 •
edited
Loading

sarama v1.32.0 has data race bug, which may cause unknown problems to tiflow kafka sink, so we revert it to v1.29.0, which was adopted by cockroach.

#5090
IBM/sarama#2171
@3AceShowHand 3AceShowHand self-assigned this Apr 2, 2022
@3AceShowHand 3AceShowHand added the type/enhancement The issue or PR belongs to an enhancement. label Apr 2, 2022
@3AceShowHand 3AceShowHand mentioned this issue Apr 2, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Apr 7, 2022
@3AceShowHand
consumer(cdc): fix unstable test move_table (#5086)
361aa92 
close #2887, close #5090, close #5101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3AceShowHand 3AceShowHand

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

consumer(cdc): fix unstable test move_table 3AceShowHand/tiflow
1 participant
@3AceShowHand