feat: add search box to hide columns popup #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgu
reviewed
Jan 31, 2023
| @@ -61,4 +61,19 @@ | |||
| .StatementResult-column-toggle-menu { | |||
| max-height: 200px; | |||
| overflow-y: auto; | |||
| .hide-column-search-bar-wrapper { | |||
| .SearchBar { | |||
There was a problem hiding this comment.
i see the same css repeated in #1136 (review)
can you make it a shared class under SearchBar.scss?
| @@ -397,29 +399,57 @@ const ColumnToggleMenuButton: React.FC<{ | |||
| }> = ({ columnNames, columnVisibility, toggleVisibility }) => { | |||
| const buttonRef = React.useRef<HTMLAnchorElement>(); | |||
| const [showPopover, _, toggleShowPopover] = useToggleState(false); | |||
| const [filteredColumnNames, setFilteredColumnNames] = useState(columnNames); | |||
There was a problem hiding this comment.
have filteredColumnNames a useMemo based on keyword and columnNames
czgu
approved these changes
Feb 1, 2023
rohan-sh1
pushed a commit
to CAI-TECHNOLOGIES/cai-ext-db-explorer
that referenced
this pull request
Apr 11, 2023
* feat: add search box to hide columns popup * feat: add clear button to hide columns search bar * chore: refactor filteredColumnNames and SearchBar
aidenprice
pushed a commit
to arrowtail-precision/querybook
that referenced
this pull request
Jan 3, 2024
* feat: add search box to hide columns popup * feat: add clear button to hide columns search bar * chore: refactor filteredColumnNames and SearchBar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a search bar to the hide columns popup to allow searching table column names with a keyword. Can select or hide all columns found with keyword.