Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make struct form fields ordered #1181

Merged
merged 1 commit into from
Feb 25, 2023
Merged

feat: make struct form fields ordered #1181

merged 1 commit into from
Feb 25, 2023

Conversation

czgu
Copy link
Collaborator

@czgu czgu commented Feb 25, 2023

Previously StructFormField was created by a dictionary of values (kwargs), but when we send the form fields to the frontend they would be come unordered. This change would now use args which is ordered. The change is backward compatible since StructFormField would still accept kwargs and then convert them into array

@czgu czgu marked this pull request as ready for review February 25, 2023 01:02
@czgu czgu merged commit 4a7c8da into pinterest:master Feb 25, 2023
@czgu czgu deleted the formv2 branch February 25, 2023 01:25
rohan-sh1 pushed a commit to CAI-TECHNOLOGIES/cai-ext-db-explorer that referenced this pull request Apr 11, 2023
aidenprice pushed a commit to arrowtail-precision/querybook that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants