Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use match_phrase_prefix on full_name field for table suggestion #1433

Merged
merged 2 commits into from
Apr 11, 2024
Merged

fix: use match_phrase_prefix on full_name field for table suggestion #1433

merged 2 commits into from
Apr 11, 2024

Conversation

jczhong84
Copy link
Collaborator

previously we were using full_name_ngram, which only works for 3 or more chars.

Here we use full_name , and only match for phrase prefix to ensure performance.

czgu
czgu previously approved these changes Apr 11, 2024
View reviewed changes
@jczhong84 jczhong84 merged commit cd11be9 into pinterest:master Apr 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czgu czgu czgu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jczhong84 @czgu