Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate markdown rendering to the frontend #349

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

czgu
Copy link
Collaborator

@czgu czgu commented Dec 10, 2020

  • Markdown rendering is done on the frontend instead of backend to skip special processing
  • Added property extraction, so things like
---
foo: bar
---
Hello

gets converted to "Hello", { foo: "bar" }.
This allows us to include extra properties with markdown and aligns with our markdown documentation format

@czgu czgu added the enhancement New feature or request label Dec 10, 2020
@czgu czgu requested a review from meowcodes December 10, 2020 21:11
@meowcodes meowcodes merged commit 455e284 into master Dec 11, 2020
@meowcodes meowcodes deleted the reactmarkdown branch December 11, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants