fix: update function configuration #4560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sivchari <shibuuuu5@gmail.com>
sivchari
requested review from
nghialv,
khanhtc1202 and
kentakozuka
as code owners
sivchari
force-pushed
the
reupdate-lambda-function-configuration
branch
from
33328a0
to
c8f35f1
Compare
khanhtc1202
reviewed
Aug 24, 2023
Comment on lines
275
to
278
| VpcConfig: &types.VpcConfig{ | ||
| SecurityGroupIds: fm.Spec.VPCConfig.SecurityGroupIDs, | ||
| SubnetIds: fm.Spec.VPCConfig.SubnetIDs, | ||
| }, |
There was a problem hiding this comment.
Should check nullity for fm.Spec.VPCConfig before call to its fields
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4560 +/- ##
==========================================
+ Coverage 29.91% 29.93% +0.01%
==========================================
Files 220 220
Lines 25873 25871 -2
==========================================
+ Hits 7741 7745 +4
+ Misses 17484 17478 -6
Partials 648 648
☔ View full report in Codecov by Sentry. |
Merged
khanhtc1202
pushed a commit
that referenced
this pull request
Aug 24, 2023
* fix: update function configuration Signed-off-by: sivchari <shibuuuu5@gmail.com> * update: check if vpc is non-nil Signed-off-by: sivchari <shibuuuu5@gmail.com> --------- Signed-off-by: sivchari <shibuuuu5@gmail.com>
khanhtc1202
pushed a commit
that referenced
this pull request
Aug 24, 2023
* fix: update function configuration Signed-off-by: sivchari <shibuuuu5@gmail.com> * update: check if vpc is non-nil Signed-off-by: sivchari <shibuuuu5@gmail.com> --------- Signed-off-by: sivchari <shibuuuu5@gmail.com>
khanhtc1202
added a commit
that referenced
this pull request
Aug 24, 2023
* fix: update function configuration (#4560) * fix: update function configuration Signed-off-by: sivchari <shibuuuu5@gmail.com> * update: check if vpc is non-nil Signed-off-by: sivchari <shibuuuu5@gmail.com> --------- Signed-off-by: sivchari <shibuuuu5@gmail.com> * Release v0.45.2 (#4561) Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> --------- Signed-off-by: sivchari <shibuuuu5@gmail.com> Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com> Co-authored-by: sivchari <shibuuuu5@gmail.com>
tokku5552
pushed a commit
to tokku5552/pipecd
that referenced
this pull request
Aug 25, 2023
* fix: update function configuration Signed-off-by: sivchari <shibuuuu5@gmail.com> * update: check if vpc is non-nil Signed-off-by: sivchari <shibuuuu5@gmail.com> --------- Signed-off-by: sivchari <shibuuuu5@gmail.com> Signed-off-by: 徳田 真之介 <tokuda_shinnosuke@cyberagent.co.jp>
sZma5a
pushed a commit
to sZma5a/pipecd
that referenced
this pull request
Aug 27, 2023
* fix: update function configuration Signed-off-by: sivchari <shibuuuu5@gmail.com> * update: check if vpc is non-nil Signed-off-by: sivchari <shibuuuu5@gmail.com> --------- Signed-off-by: sivchari <shibuuuu5@gmail.com> Signed-off-by: sZma5a <masaaki.haribote@gmail.com>
moko-poi
pushed a commit
to moko-poi/pipecd
that referenced
this pull request
Nov 3, 2023
* fix: update function configuration Signed-off-by: sivchari <shibuuuu5@gmail.com> * update: check if vpc is non-nil Signed-off-by: sivchari <shibuuuu5@gmail.com> --------- Signed-off-by: sivchari <shibuuuu5@gmail.com> Signed-off-by: moko-poi <mokopoi44@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
@khanhtc1202
I'm so sorry, update function configuration has been already defined and called. So I deleted my changes.
And I fixed order to call UpdateFunctionCode and UpdateFunctionConfiguration. Because UpdateFunctionConfiguration is failed, if Lambda state is pending.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: