Put tags and categories to blog pages #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
t-kikuc
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
Warashi
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4959 +/- ##
==========================================
- Coverage 29.38% 29.35% -0.04%
==========================================
Files 322 322
Lines 40852 40852
==========================================
- Hits 12006 11993 -13
- Misses 27885 27899 +14
+ Partials 961 960 -1 ☔ View full report in Codecov by Sentry. |
khanhtc1202
reviewed
Jun 7, 2024
| @@ -5,6 +5,8 @@ linkTitle: "May 2022 update" | |||
| weight: 993 | |||
| description: "Development status update to recap what happened last few months" | |||
| author: Khanh Tran ([@khanhtc1202](https://twitter.com/khanhtc1202)) | |||
| categories: ["Announcement"] | |||
| tags: ["What's new"] | |||
There was a problem hiding this comment.
Suggested change
| tags: ["What's new"] | |
| tags: ["News"] |
nits
khanhtc1202
reviewed
Jun 7, 2024
| @@ -4,6 +4,8 @@ title: "PipeCD at CNCF KubeCon EU 2024" | |||
| linkTitle: "PipeCD at CNCF KubeCon EU 2024" | |||
| weight: 988 | |||
| author: Khanh Tran ([@khanhtc1202](https://github.com/khanhtc1202)) | |||
| categories: ["Announcement"] | |||
| tags: ["Conference"] | |||
There was a problem hiding this comment.
Suggested change
| tags: ["Conference"] | |
| tags: ["Conference", "News"] |
nits
khanhtc1202
reviewed
Jun 7, 2024
| @@ -5,6 +5,8 @@ linkTitle: "The PipeCD play environment" | |||
| weight: 994 | |||
| description: "In this post, we will have a glance at the play environment of PipeCD, how to access and what you can get from the environment." | |||
| author: Khanh Tran ([@khanhtc1202](https://twitter.com/khanhtc1202)) | |||
| categories: ["Announcement"] | |||
| tags: ["Getting Started"] | |||
There was a problem hiding this comment.
Suggested change
| tags: ["Getting Started"] | |
| tags: ["Getting Started", "News"] |
Signed-off-by: t-kikuc <[email protected]>
|
@khanhtc1202 Thanks! I fixed them all! plz check again 🙏 |
|
I opened an issue #4965 because the tags and the categories do not appear. |
Closed
dgannon991
pushed a commit
to dgannon991/pipecd-pipecd
that referenced
this pull request
Jun 20, 2024
Signed-off-by: t-kikuc <[email protected]> Signed-off-by: David Gannon <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
as title.
Which issue(s) this PR fixes:
Fixes #4958
Does this PR introduce a user-facing change?: N/A
Example
each blog page:
search by category (click any category):
search by tag (click any tag):