Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to RELEASE file #5149

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Add note to RELEASE file #5149

merged 1 commit into from
Aug 19, 2024

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Add note to aware release facilitator to use make release command instead of update this file manually 😅

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link
Contributor

RELEASE

No GitHub releases will be created one this pull request got merged. Because the following tags were already created before.

  • v0.48.6

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.79%. Comparing base (71b46e0) to head (053ad2c).
Report is 54 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5149   +/-   ##
=======================================
  Coverage   22.79%   22.79%           
=======================================
  Files         412      412           
  Lines       43827    43827           
=======================================
+ Hits         9989     9992    +3     
+ Misses      33050    33047    -3     
  Partials      788      788           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good note👍
make release/init worked well even after fixing it.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@khanhtc1202 khanhtc1202 merged commit deecab6 into master Aug 19, 2024
19 checks passed
@khanhtc1202 khanhtc1202 deleted the add-note-release branch August 19, 2024 04:07
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Warashi added a commit that referenced this pull request Aug 26, 2024
* Add note to RELEASE file (#5149)

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Fix the kubernetes manifest diff (#5154)

* Add TestLoadAndDiff

Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com>

* Make testcase smaller

Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com>

* Separate test cases

Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com>

* Add test cases

Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com>

* FIx the k8s diff

normalize both of old and new manifests

Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com>

* Rename the testcase

Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com>

---------

Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

* Release v0.48.7 (#5157)

Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>

---------

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Signed-off-by: Shinnosuke Sawada <6warashi9@gmail.com>
Co-authored-by: Khanh Tran <32532742+khanhtc1202@users.noreply.github.com>
Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
This was referenced Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants