Add force-sync-by-replace annotation option #5175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5175 +/- ##
==========================================
+ Coverage 22.88% 22.90% +0.02%
==========================================
Files 416 416
Lines 44607 44690 +83
==========================================
+ Hits 10208 10238 +30
- Misses 33607 33660 +53
Partials 792 792 ☔ View full report in Codecov by Sentry. |
ffjlabo
previously approved these changes
Sep 3, 2024
| @@ -137,6 +139,32 @@ func (a *applier) ReplaceManifest(ctx context.Context, manifest Manifest) error | |||
| return err | |||
| } | |||
|
|
|||
| // ReplaceManifest uses kubectl to replace the given manifests. | |||
There was a problem hiding this comment.
[nit] ReplaceManifest -> ForceReplaceManifest
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Add test for force-sync-by-replace Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Add ForceReplaceManifest methods Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Add force-sync-by-replace handling Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> * Fix the godoc comment Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> --------- Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com>
Merged
Warashi
added a commit
that referenced
this pull request
Sep 4, 2024
* Add test for force-sync-by-replace * Add ForceReplaceManifest methods * Add force-sync-by-replace handling * Fix the godoc comment --------- Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev> Signed-off-by: pipecd-bot <pipecd.dev@gmail.com> Co-authored-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add an option to replace the Kubernetes resources forcefully.
Which issue(s) this PR fixes:
Fixes #5174
Does this PR introduce a user-facing change?:
Yes
How are users affected by this change:
Users can replace resources forcefully.
This allows users to run the k8s job each time deployment occurs.
Is this breaking change: No
How to migrate (if breaking change): N/A