Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListDeprecatedNotes endpoint to web api #5198

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #5197

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 22.86%. Comparing base (ac32fda) to head (7bc2ca4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/server/grpcapi/web_api.go 0.00% 2 Missing ⚠️
...g/app/server/service/webservice/service.pb.auth.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5198   +/-   ##
=======================================
  Coverage   22.85%   22.86%           
=======================================
  Files         420      420           
  Lines       45245    45249    +4     
=======================================
+ Hits        10340    10344    +4     
- Misses      34109    34110    +1     
+ Partials      796      795    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@khanhtc1202 khanhtc1202 merged commit 9f5bd67 into master Sep 6, 2024
16 of 17 checks passed
@khanhtc1202 khanhtc1202 deleted the add-list-deprecated-note-endpoint branch September 6, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants