Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove retry_policy and make timeout longer #5203

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Sep 9, 2024

What this PR does / why we need it:

Make ext-authz-filter timeout longer, and remove retry_policy.

I realized that the Authz RPC is sometimes slow in the dev environment. So, I made the timeout longer.
After I checked the envoy log, the retry did not occur when the request was timeouted. So, I removed the retry_policy.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.81%. Comparing base (032e430) to head (19a429e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5203      +/-   ##
==========================================
- Coverage   22.82%   22.81%   -0.02%     
==========================================
  Files         420      420              
  Lines       45302    45302              
==========================================
- Hits        10340    10335       -5     
- Misses      34166    34172       +6     
+ Partials      796      795       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Warashi Warashi merged commit 6d8c7e9 into master Sep 9, 2024
16 of 17 checks passed
@Warashi Warashi deleted the gateway-ext-authz-timeout-longer branch September 9, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants