Enable the persistence of the Grafana Tempo #5208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
nghialv,
khanhtc1202,
kentakozuka,
ffjlabo and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5208 +/- ##
==========================================
- Coverage 22.83% 22.81% -0.03%
==========================================
Files 420 420
Lines 45302 45302
==========================================
- Hits 10344 10334 -10
- Misses 34163 34172 +9
- Partials 795 796 +1 ☔ View full report in Codecov by Sentry. |
Warashi
added a commit
that referenced
this pull request
Sep 12, 2024
This reverts commit 41ae6d1. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
added a commit
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Without this PR, the traces are lost when the tempo pod is evicted.
The StatefulSet manages the tempo's pod, so usually it does not occur, but it occurs with the times such as when the configmap is changed.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: Yes only if users use the control plane version v0.49.0-rc0
How are users affected by this change:
When users using control plane helm chart with monitoring.enabled as true, they cannot upgrade the control plane without manual operation.
Is this breaking change: Yes
How to migrate (if breaking change):
Delete the Grafana Tempo's StatefulSet before applying the Helm Chart.