feat: Add Piscina#close API
#396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
reviewed
Aug 31, 2023
andersonjoseph
force-pushed
the
graceful-close
branch
2 times, most recently
from
99f11da
to
08e995b
Compare
andersonjoseph
force-pushed
the
graceful-close
branch
2 times, most recently
from
4909721
to
41233ca
Compare
metcoder95
reviewed
Sep 6, 2023
metcoder95
reviewed
Sep 7, 2023
metcoder95
reviewed
Sep 7, 2023
metcoder95
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everyone!
This PR adds a new method called
close(). It allows you to stop all the workers in a pool gracefully (closes: #139)Please let me know if you have any feedback or suggestions for improvement. I'm happy to make any changes if needed.