-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add state properties to worker #620
Conversation
src/worker_pool/index.ts
Outdated
currentUsage: this.currentUsage(), | ||
isRunningAbortableTask: this.isRunningAbortableTask(), | ||
get id () { | ||
return parent.worker.threadId.toString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why to string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its a number by default, was wondering if shall we keep it like this or better parse it as string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to keep it as a number. More efficient to use than a string.
Co-authored-by: Robert Nagy <ronagy@icloud.com>
No description provided.