Added support for multiple fixes per block in fix-file-resouce-leak #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clavedeluna
reviewed
Feb 8, 2024
| ) | ||
| # is closed? | ||
| name_condition = map( | ||
| # pylint: disable-next=cell-var-from-loop |
There was a problem hiding this comment.
hmmm either this pylint warning is worth listening to or it's a pylint bug? Either way, maybe a list-comp is easier to read here?
There was a problem hiding this comment.
I wanted to avoid building the list since the result would just be fed into all. I don't exactly remember the issue with the warning was. It may be invalid by now. I'll try to remove and see if it still complains.
clavedeluna
approved these changes
Feb 8, 2024
andrecsilva
force-pushed
the
multi-fresource-leak
branch
from
4002e13
to
f549be1
Compare
drdavella
approved these changes
Feb 13, 2024
| file_context: FileContext, | ||
| *codemod_args, | ||
| *codemod_args, # pylint: disable=unused-argument |
There was a problem hiding this comment.
Small thing but I think the idiomatic way to suppress this is with
del *codemod_argsAlthough possibly this argument is no longer needed?
andrecsilva
force-pushed
the
multi-fresource-leak
branch
from
f549be1
to
f380d9a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix-file-resource-leakwill now fix multiple leaks in a single block at once