Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generated diff when adding hashes to requirements.txt #403

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Fix generated diff when adding hashes to requirements.txt #403

merged 1 commit into from
Mar 22, 2024

Conversation

drdavella
Copy link
Member

Overview

Fix generated diff when adding hashes to requirements.txt

Description

  • This is pretty subtle but there was a bug when generating the diff for requirements.txt files when hashes are added
  • The effect of the changes on disk are the same, since that was working just fine
  • But in order to properly create the diff, each changed line needs to be represented as a separate list item when given to the diff generator

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@drdavella drdavella added this pull request to the merge queue Mar 22, 2024
Merged via the queue into main with commit 0611a89 Mar 22, 2024
13 checks passed
@drdavella drdavella deleted the fix-requirements-hash-diff branch March 22, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrecsilva andrecsilva andrecsilva approved these changes

@clavedeluna clavedeluna Awaiting requested review from clavedeluna clavedeluna is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@drdavella @andrecsilva