Parallelize integration tests #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clavedeluna
force-pushed
the
int-test-faster
branch
from
66e0260
to
097bc46
Compare
clavedeluna
force-pushed
the
int-test-faster
branch
from
097bc46
to
f9e1609
Compare
drdavella
approved these changes
Mar 26, 2024
| class TestDependencyManager(CleanRepoMixin): | ||
| output_path = "test-codetf.txt" | ||
| class TestDependencyManager: | ||
| output_path = tempfile.mkstemp()[1] |
There was a problem hiding this comment.
Would it make more sense to do this within setup_class?
|
|
||
| cls.code_path = os.path.join(cls.code_dir, cls.code_filename) | ||
|
|
||
| if cls.code_filename == "settings.py" and "Django" in str(cls): |
There was a problem hiding this comment.
It feels like maybe this should just happen in a Django-specific subclass.
There was a problem hiding this comment.
very very true. Honestly I was just trying to make as few changes to specific integration test files as possible. Just for now I'm going to leave it as is.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Be able to run all integration-tests in parallel for speed
Description
replacement_linesbe 1-index as this was confusing to see compared withexpected_line_change. It didn't make sense to have these lines be 0-index when everything else for line changes is 1-indexed.Additional Details
test_sonar_fix_missing_self_or_clsis missing theis_node_selectedcheck, it passes when it shouldn't. This is because I hadn't updated sonar_issues.json because nothing reminded me to do so. I'll ticket this and thoughts around how to prevent this issue.