Fix default path include/exclude behavior; update codemod hierarchy #780
Conversation
drdavella
force-pushed
the
fix-path-include-exclude
branch
from
f1a91ce
to
72b80cc
Compare
| @@ -6,7 +6,9 @@ | |||
| "pixee:python/add-requests-timeouts", | |||
| "pixee:python/secure-random", | |||
| "pixee:python/sandbox-process-creation", | |||
| "pixee:python/subprocess-shell-false", | |||
There was a problem hiding this comment.
This one is a result of adding --dry-run (which I was using locally while testing).
| "pixee:python/django-session-cookie-secure-off", | ||
| "pixee:python/django-model-without-dunder-str", |
There was a problem hiding this comment.
I'm not really sure how to account for this change 😅
There was a problem hiding this comment.
this is really surprising... I can see pygoat django Model classes that would merit this codemod, but why this wasn't getting triggered before 🤷
| # run codemods one at a time making sure to respect the given sequence | ||
| for codemod in codemods_to_run: | ||
| # NOTE: this may be used as a progress indicator by upstream tools | ||
| logger.info("running codemod %s", codemod.id) | ||
|
|
||
| if isinstance(codemod.detector, SemgrepRuleDetector): |
There was a problem hiding this comment.
This filtering logic is now handled by the codemod itself.
|
| "pixee:python/django-session-cookie-secure-off", | ||
| "pixee:python/django-model-without-dunder-str", |
There was a problem hiding this comment.
this is really surprising... I can see pygoat django Model classes that would merit this codemod, but why this wasn't getting triggered before 🤷
Overview
Update default path include/exclude behavior; update codemod hierarchy
Description
.git,*.pyc, etc.)CodemodExecutionContextwhere it can be easily cached and reused