New Sast Regex transformer #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clavedeluna
force-pushed
the
sast-regex
branch
from
186c254
to
0eb723d
Compare
|
andrecsilva
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a sast-specific regex transformer. This allows us to have the assumption that a particular line will need a particular fix, since otherwise the sast tool wouldn't have made the result.
This will partially address concerns in #603 as some codemods that use the XML parser may be able to be moved to this. I still have to figure out if we will handle the cases of "the attribute is entirely missing", instead of just match replace. But this regex sast transformer has already let me switch out two non-deterministic codemods.