Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support customization of selector in SelectorSelectorControl component #688

Closed
2 tasks
twschiller opened this issue Jul 3, 2021 · 0 comments · Fixed by #1059
Closed
2 tasks

Support customization of selector in SelectorSelectorControl component #688

twschiller opened this issue Jul 3, 2021 · 0 comments · Fixed by #1059
Assignees
@BLoe
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers priority user experience Improve the user experience (UX)

Comments

@twschiller
Copy link
Contributor

twschiller commented Jul 3, 2021 •
edited
Loading

The SelectorSelectorControl component which is used as the editor for fields with format selector has some limitations:

  • Pasting a selector (e.g., one the you've copied from the Chrome Elements tab) is buggy
  • User cannot modify a selector once they've selected it

Considerations

  • Might have to abandon using https://react-select.com/creatable for the base component. Is should potentially be a "text" field that also happens to have a dropdown handle for viewing suggestions

References:
@twschiller twschiller added bug Something isn't working enhancement New feature or request user experience Improve the user experience (UX) labels Jul 3, 2021
@twschiller twschiller changed the title Enable customization of selector in SelectorSelectorControl component Support customization of selector in SelectorSelectorControl component Jul 6, 2021
@twschiller twschiller self-assigned this Jul 7, 2021
@twschiller twschiller removed their assignment Jul 31, 2021
@twschiller twschiller added the good first issue Good for newcomers label Jul 31, 2021
@BLoe BLoe mentioned this issue Aug 13, 2021
Merged
BLoe added a commit that referenced this issue Aug 13, 2021
@BLoe
#688 New Autosuggest component for SelectorSelectorField (#1059)
d7186b5
twschiller added a commit that referenced this issue Aug 17, 2021
@twschiller
#688: handle selector array corner-case
c9ec1ed
twschiller added a commit that referenced this issue Aug 17, 2021
@twschiller
#688: handle selector array corner-case (#1096)
7680d50
@fregante fregante mentioned this issue Mar 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BLoe BLoe

Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers priority user experience Improve the user experience (UX)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#688 New Autosuggest component for SelectorSelectorField pixiebrix/pixiebrix-extension
2 participants
@twschiller @BLoe