Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managed extension policy not taking effect on some extension startups #7618

Closed
twschiller opened this issue Feb 14, 2024 · 1 comment · Fixed by #7628
Closed

Managed extension policy not taking effect on some extension startups #7618

twschiller opened this issue Feb 14, 2024 · 1 comment · Fixed by #7628
Assignees
Labels
bug Something isn't working enterprise
Milestone

Comments

@twschiller
Copy link
Contributor

twschiller commented Feb 14, 2024

Describe the bug

  • Managed policy wasn't taking effect on a browser profile startup (upon opening Chrome for after logging into a VDI)
  • For the enterprise customer using SSO, this meant PixieBrix opened that standard login page vs. showing the SSO flow and restricting URLs according to the organization policy
  • We have some logic to try to account for flakiness in when Chrome makes the policy available:
    const waitForInitialManagedStorage = pMemoize(async () => {
  • However, some of the code won't recover from the policy not being found on initial startup
  • When we checked the chrome://policy page, the settings were there. So it looks like the policy came through but our extension wasn't aware of it on initial startup
  • When we closed Chrome and re-opened it, it worked as expected

Discussion

  • The challenge of adding blocking for reading the managed storage policy is that it delays showing login screen for normal users who don't need the policy

To Reproduce

  • Can't reproduce reliably due to flakiness of managed storage

Actual behavior

A clear and concise description of what happened that shouldn't

Expected behavior

  • PixieBrix reads the policy and opens SSO flow and applies organization restrictions

Desktop (please complete the following information):

  • OS: Windows (which version?)
  • Browser: Chrome
  • Extension Version: 1.8.8
@twschiller twschiller added bug Something isn't working enterprise labels Feb 14, 2024
@twschiller twschiller added this to the 1.8.9 milestone Feb 14, 2024
@twschiller twschiller changed the title Managed extension policy not taking effect sometimes Managed extension policy not taking effect on some extension startups Feb 14, 2024
@twschiller twschiller self-assigned this Feb 14, 2024
@twschiller
Copy link
Contributor Author

I opened a w3c issue here to try to get clarity on intended behavior: w3c/webextensions#547

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enterprise
Projects
None yet
1 participant