Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from node-sass to dart-sass #975

Closed
twschiller opened this issue Aug 3, 2021 · 5 comments · Fixed by #4838
Closed

Switch from node-sass to dart-sass #975

twschiller opened this issue Aug 3, 2021 · 5 comments · Fixed by #4838
Labels
dependencies Pull requests that update a dependency file developer experience

Comments

@twschiller
Copy link
Contributor

twschiller commented Aug 3, 2021

Context

@fregante
Copy link
Collaborator

fregante commented Aug 15, 2021

Blocked by:

Dart sass produces a lot of warnings on Bootstrap’s code and Bootstrap isn't even tracking this issue.

@fregante
Copy link
Collaborator

I investigated this and yes, probably switching to Bootstrap 5 would fix these issues, but from what I see we can't do that because we vendored the entire theme. That's why when I tried to install v5 I still got errors.

Example:

blue: $blue,
indigo: $indigo,
purple: $purple,
pink: $pink,
red: $red,
orange: $orange,
yellow: $yellow,
green: $green,
teal: $teal,
cyan: $cyan,
white: $white,
gray: #434a54,
gray-light: #aab2bd,
gray-lighter: #e8eff4,
gray-lightest: #e6e9ed,
gray-dark: #0f1531,
black: #000000,

Fixed in v5 a few years ago: twbs/bootstrap#23701


In short, the switch is blocked by:

@twschiller
Copy link
Contributor Author

There's a pure JS version of dart-sass at: https://www.npmjs.com/package/sass

@fregante
Copy link
Collaborator

Yes that's the one I used in https://github.com/pixiebrix/pixiebrix-app/pull/465 as well

@fregante
Copy link
Collaborator

If desired, I suppose I can fix the issues in the vendored theme. I don’t think we're going to "upgrade" the theme to a later version at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file developer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants