-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from node-sass to dart-sass #975
Comments
Blocked by: Dart sass produces a lot of warnings on Bootstrap’s code and Bootstrap isn't even tracking this issue. |
I investigated this and yes, probably switching to Bootstrap 5 would fix these issues, but from what I see we can't do that because we vendored the entire theme. That's why when I tried to install v5 I still got errors. Example: pixiebrix-extension/src/vendors/theme/assets/styles/_variables.scss Lines 21 to 37 in a5521ed
Fixed in v5 a few years ago: twbs/bootstrap#23701 In short, the switch is blocked by:
|
There's a pure JS version of dart-sass at: https://www.npmjs.com/package/sass |
Yes that's the one I used in https://github.com/pixiebrix/pixiebrix-app/pull/465 as well |
If desired, I suppose I can fix the issues in the vendored theme. I don’t think we're going to "upgrade" the theme to a later version at this point. |
Context
@use
), https://sass-lang.com/documentation/at-rules/useThe text was updated successfully, but these errors were encountered: