#2557 Part 1 - Show blueprints in sidebar #2590
Conversation
|
@BLoe This looks like a good start. What would be involved in feature flagging the blueprint work? This kind of work has the potential to become a long-lived branch |
|
I just pushed a commit that puts the blueprint grouping in the sidebar behind the beta feature flag. It'll be a little bit more complicated to manage the tabs and stuff but should be possible. |
|
Can you give me a few short instructions on how to see this new UI? Do I have to install one or more blueprints from the new blueprints page? |
Activate any blueprint from the marketplace or my-blueprints page, then open the page editor. You also need the |
|
@fregante @BALEHOK I think we should try to get this merged in despite the intermediate state of things, due to the fact that all 3 of us are making page editor layout/css changes right now. Everything here should be contained behind the I'm open to really thorough thoughts/feedback/whatever from anyone, since this affects everything in the page editor. We can also try and huddle up on slack or otherwise have a discussion about things if anyone thinks that would be helpful. |
| index | ||
| ) => ( | ||
| <Button | ||
| key={index} // Action buttons shouldn't normally be changing order |
There was a problem hiding this comment.
index is ok, caption will do as well I believe.
…ndering the layout
|
@twschiller @fregante @BALEHOK I added the tests I wanted to for the grouping logic. I think we should try and get this merged now, but would welcome any feedback from anyone if you guys feel like reviewing it. |
| onClick: saveRecipe, | ||
| caption: "Save", | ||
| disabled: isSavingRecipe, | ||
| icon: faSave, |
There was a problem hiding this comment.
It seems that this is reimplementing the ElementWizard’s nav from scratch (duplicating it) and is incompatible with my PR because the styles are no longer global:
Probable solution:
- move nav to its own component and reuse it
Starts the work for #2557.
Apologies for the size of this PR 😅
The main changes are:
activeExtensionstuff to reduxEditorTabLayoutcomponent that is domain agnostic, it just knows how to render a tab layout with action buttons in the top rightRecipePanefor selected recipes