Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7071: drop gapi requirements from CSP #7072

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

twschiller
Copy link
Contributor

@twschiller twschiller commented Dec 7, 2023

What does this PR do?

Discussion

  • I think we still want to include https://*.googleapis.com/* in exclude matches because we know our content script should never run in that frame?

Checklist

  • Add tests: will be reviewed by rainforest/regression tests for google
  • New files added to src/tsconfig.strictNullChecks.json (if possible): N/A
  • Designate a primary reviewer: @BLoe

@twschiller twschiller added this to the 1.8.5 milestone Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ac277e1) 71.19% compared to head (d960729) 71.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7072   +/-   ##
=======================================
  Coverage   71.19%   71.19%           
=======================================
  Files        1209     1209           
  Lines       37384    37384           
  Branches     7010     7010           
=======================================
  Hits        26615    26615           
  Misses      10769    10769           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 7, 2023

No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack.

Do not edit this comment manually.

@twschiller twschiller merged commit f15dac9 into main Dec 7, 2023
14 checks passed
@twschiller twschiller deleted the feature/7071-drop-gapi-csp branch December 7, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary gapi entries from the manifest CSP
3 participants