Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add journal brand tool from Beyond the Theme workshop #571

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

NateWr
Copy link
Contributor

@NateWr NateWr commented Dec 17, 2020

I've adapted @sssoz's journal branding tool from the Beyond the Theme workshop so that it can be given a permanent home in the docs hub. I just made a few modifications to add the PKP|Docs header.

design-adventure

@amandastevens and @kaitlinnewson a lot of people expressed interest in Barcelona in seeing this made a part of our documentation. It's most obvious home is somewhere in/alongside the Designing Your Journal guide, but it needs to be a stand-alone page (it can't be a "chapter" of the guide). So it could be that this is linked to from the Designing Your Journal card, and then linked from the introduction or something. I'm not sure exactly the best way to add it so that it's discoverable. Do you have any ideas?

@sssoz I had to do a bit of hacking to merge your index.html in with the docs hub layout, but I think I've left it intact other than adding the PKP|Docs header. If you have a minute to test it out that'd be great, but no hurry.

@sssoz
Copy link
Contributor

sssoz commented Dec 17, 2020

@NateWr I don’t really have time but a quick note -- could you use the Docs logo that we’ve designed some time ago? This is probably the right opportunity to start using them. https://pkp-logotypes.netlify.app/

@amandastevens
Copy link
Contributor

This is great! Kaitlin can better answer these questions and she is on holidays until January.

@kaitlinnewson
Copy link
Member

I agree that it would make the most sense to link to it both from the card, and from the intro of the "designing your journal" guide. We can also add it to the "additional resources" page of that guide.

One small difference I noticed in this new version is the link styles - in the original version they are underlined, so it's more clear that they are clickable links.

@sssoz
Copy link
Contributor

sssoz commented Jan 25, 2021

@NateWr

Besides the logo needing to be replaced, could you remove my e-mail address & squash that commit to the one in this PR so there’s no history of my address in the repo? Just my GH should suffice. It would also be nice to get the credit for developing the tool & the copy within it! Thanks!

Base automatically changed from master to main February 18, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants