-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Web of Science Reviewer Recognition Service plugin for OJS 3.4 #301
base: main
Are you sure you want to change the base?
Conversation
Hi PKP team, can we please get this PR reviewed? |
@@ -9768,6 +9768,41 @@ | |||
<description>Minor improvements for Portuguese translations.</description> | |||
</release> | |||
</plugin> | |||
<plugin category="generic" product="webOfScience"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Alex-nz, thanks a lot for the contribution!
I went through the plugin code and would have a few comments/questions:
- The handler https://github.com/clarivate/wos_reviewer_recognition_plugin_ojs_3/blob/main/WOSHandler.php is missing the authorization function. This way everybody could call the function
exportReview
. I believe thataddRoleAssigment
should be used, so that only reviewers (an user with a reviewer role) can call the function, and it should also be checked if the request context corresponds to the submission context (having the submission from the reviewAssignment) -- so that a reviewer from one journal cannot call that function for a review in another journal (that maybe has no plugin enabled) -- e.g. if the parameterreviewId
, that the function expects, would be manipulated. I believe the WOS service would surely not work correctly for example in case the user is not a reviewer any more, or for a review in another journal, but the safety should be ensured by coding it. - When are these lines the case: https://github.com/clarivate/wos_reviewer_recognition_plugin_ojs_3/blob/main/WOSHandler.php#L191 and https://github.com/clarivate/wos_reviewer_recognition_plugin_ojs_3/blob/main/WOSHandler.php#L214 -- when and how would
$_SERVER["HTTP_WOS_URL"]
be set? - Instead of using php curl you should rather use Guzzle -- you can get the HTTP client from the
Application
class. This client is properly configured for proxies if the server is behind one. - I think
<certification type="reviewed"/>
should be used below.
Please let me know if you would have any questions and what do you think about the suggestions...
Thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @bozana , we've made the requested updates and updated the PR, can you please re-review?
^ I've used the same certification type that we were given when published the plugin previously, under Publons name. I have updated it to "reviewed" as you suggested. |
Hi @Alex-nz,
And finally, let me double check regarding the certification level with the team... Thanks a lot! |
I have forgotten to include @v0k1c into my comment above :-( Sorry! But now... :-) |
Hi @bozana! I've just double checked, and Open Sans (although available within the theme plugin?) is not loaded by default? All I'm seeing that is loaded is Noto Sans and Fontawesome. Would it be safe to import/enable it through theme plugin, or what is the preferred way to use additional fonts that are available there? Asking because I can't find anything related to this within the available documentation. |
Add Web of Science Reviewer Recognition Service plugin for OJS 3.4 into the plugin gallery. This plugin is the heavily rebranded old Publons plugin, hence I put these together in the file.