Use dedent indents consistently

[mnaoumov]

Fixes #311

[pjkaufman]

Do you mind explaining what is inconsistent about the use of dedent here?

[pjkaufman]

I think I understand now. Did the linter not undo the change you are referring to?

[pjkaufman]

If we are making this change, we need a way to enforce it via the linter or a config that works for several editors.

[mnaoumov]

@pjkaufman no, linter doesn't touch those changes. eslint is not aware of dedent, so it can't change anything. I'm looking if we can write our own rules for eslint

[mnaoumov]

This looks promising https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/template-indent.md

[mnaoumov]

@pjkaufman I configured the linter rule to have dedent strings consistent. Also worked around those hard-to-catch cases with deliberate trailing spaces

[pjkaufman]

I am not sure I agree with removing blank lines or trailing space. Can we not use a setting on the rule to avoid the hacky solution?

[pjkaufman]

This feels very hacky.

[mnaoumov]

I checked the source code of the plugin

https://github.com/sindresorhus/eslint-plugin-unicorn/blob/20e959ffadeca007697534f1ad58c45d29cfdb04/rules/template-indent.js#L72

They do unconditional trimming.

I'll send them a PR to make it configurable

But honestly invisible trailing spaces are difficult to read anyway. With this "hack" we improve code readability

[pjkaufman]

I will take a closer look later on today.

[mnaoumov]

sindresorhus/eslint-plugin-unicorn#1868

[pjkaufman]

It looks like there should be a tab present here based on the text. But maybe that is incorrect.