Upgraded whereabouts #127
Merged
Upgraded whereabouts #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed ipReconcilerNodeSelector is redundant
joey00072
requested review from
cruizen,
srinivaschavan,
vedantjoshi84 and
jayanth-tjvrr
jayanth-tjvrr
approved these changes
Jan 8, 2024
vedantjoshi84
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re upgrading
platform9/whereabouts:v0.6-pmk-2871011ip-reconcileris removed, in whereabouts version 6Reconciliation happen inside pod and can be configured with configmap
ipReconcilerNodeSelector field in NetworkPlugins is redundant. Reconciler works within pod
However logic is not removed for backward compatibility
Test