Fix hostplumber v0.5.4 #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cruizen
requested review from
poojaghumre,
mithilarun,
joey00072,
manasabsv26 and
a team
Merged
mithilarun
approved these changes
Mar 6, 2024
|
This should fix the lack of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stick to Alpine 3.16 in Hostplumber : Backport to v0.5.4 branch
Reason : Hostplumber build uses
libexecinfoandlibexecinfo-devwhich has been removed in Alpine 3.17 - build fails in Teamcity with higher version of AlpineDataDog/dd-trace-php#1824
TODO: Can look into workarounds later to be able to support alpine 3.17 or higher
YMMV : awslabs/aws-lambda-cpp#124 (comment)
Teamcity builds :
luigi-plugins : https://teamcity.platform9.horse/buildConfiguration/Pf9project_Platform9ComponentsForKubernetes_LuigiPlugins/3167489
hostplumber : https://teamcity.platform9.horse/buildConfiguration/Pf9project_Platform9ComponentsForKubernetes_Hostplumber/3167492