Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major(deps): Upgrade to Guice v7 #239

Merged
merged 7 commits into from
Feb 2, 2024
Merged

major(deps): Upgrade to Guice v7 #239

merged 7 commits into from
Feb 2, 2024

Conversation

erwinw
Copy link
Member

@erwinw erwinw commented Jan 27, 2024

Upgrade to Guice v7

BREAKING CHANGE: This drops support for javax.inject in favor of jakarta.inject. com.google.inject is still supported.

@erwinw erwinw added the dependencies Pull requests that update a dependency file label Jan 27, 2024
@erwinw erwinw self-assigned this Jan 27, 2024
@erwinw erwinw changed the title Upgrade to Guice v7 major(deps): Upgrade to Guice v7 Jan 27, 2024
@erwinw erwinw marked this pull request as ready for review January 29, 2024 19:24
@erwinw erwinw requested a review from a team January 29, 2024 19:24
@erwinw
Copy link
Member Author

erwinw commented Jan 29, 2024

Hey @jsfr do you recall how we are supposed to version and release Prop?

@erwinw erwinw requested review from jsfr and andriygg January 29, 2024 19:25
@jsfr
Copy link
Contributor

jsfr commented Jan 29, 2024

Hey @jsfr do you recall how we are supposed to version and release Prop?

Not really. But looking at the workflows it looks like it's using auto with labels.

# Conflicts:
#	prop-all/src/test/kotlin/io/pleo/prop/objects/BothNamedAnnotations.kt
Copy link
Contributor

@andriygg andriygg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, E! 👍

@@ -20,7 +20,8 @@ import java.lang.reflect.ParameterizedType
import java.lang.reflect.Type
import java.util.Optional.ofNullable
import java.util.function.Predicate
import javax.inject.Named
import com.google.inject.name.Named as JuiceNamed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small alias naming inconsistency, in another place it was GoogleNamed

@erwinw erwinw enabled auto-merge (squash) February 2, 2024 09:55
@erwinw erwinw merged commit 30552c5 into main Feb 2, 2024
6 checks passed
@erwinw erwinw deleted the chore/bump-juice-v7 branch February 2, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

3 participants