feat(bubble): trigger onClick when isZoomable is false (#322)

plouc · Oct 23, 2018 · 787341a · 787341a
1 parent 1b1b6d9
commit 787341a
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/packages/circle-packing/src/interactivity.js b/packages/circle-packing/src/interactivity.js
@@ -48,6 +48,10 @@ export const getNodeHandlers = (
             onClick(node, event)
             zoomToNode(node.path)
         }
+    } else {
+        clickHandler = event => {
+            onClick(node, event)
+        }
     }
 
     return {

diff --git a/packages/circle-packing/tests/Bubble.test.js b/packages/circle-packing/tests/Bubble.test.js
@@ -1,5 +1,5 @@
 import React from 'react'
-import { render } from 'enzyme'
+import { render, mount } from 'enzyme'
 import Bubble from '../src/Bubble'
 
 const sampleData = {
@@ -63,3 +63,26 @@ it(`should allow to skip labels using 'labelSkipRadius' if radius is lower than
 
     expect(wrapper.find('text').length).toBe(6)
 })
+
+it(`should send node data to onClick when 'isZoomable' is false`, () => {
+    const onClickHandler = jest.fn(node => node.data)
+    const wrapper = mount(
+        <Bubble
+            width={600}
+            height={600}
+            root={sampleData}
+            enableLabel={true}
+            labelSkipRadius={24}
+            isZoomable={false}
+            onClick={onClickHandler}
+        />
+    )
+
+    wrapper
+        .find('circle')
+        .at(0) //click the first <circle> (the root)
+        .simulate('click')
+
+    expect(onClickHandler.mock.calls.length).toBe(1)
+    expect(onClickHandler.mock.results[0].value).toEqual(sampleData)
+})