-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(calendar): expose weekdayTicks prop on TimeRange component #1634
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5856e09:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just want a more strict type.
Also, can you merge master or rebase. I merged in a PR containing the changes you have in .storybook
folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
On the new TimeRange component, the weekday tick marks are set to Monday/Wednesday/Friday. This PR gives the user an option to change them, or remove them altogether by passing an empty array.
Updates were made to the Storybook showing both alternative options.