(feat)Line: add support for hiding line charts by default #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b9ae884:
|
|
Wow galing |
|
Thank you for this @clcatalan! Could you please add tests for this new feature? |
|
hi @plouc added unit tests, all Line unit tests still pass as expected 
|
plouc
requested changes
Jun 26, 2024
plouc
reviewed
Jul 8, 2024
plouc
requested changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue for: #2481
Solution is for user to simply pass an array of keys in the initialHiddenIds props for the Line Chart. This toggles the legend to "off" by default. The app consuming nivo should do the computation to determine if a key should be hidden or not.
*this is what it looks like on load, the cognac line is hidden by default
