This repository has been archived by the owner on Jul 4, 2022. It is now read-only.
"Implement FixedPoint trait" and "Enable fixed point u128" #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliXsed
force-pushed
the
fix/141-weight-multiplier
branch
from
c5280a6
to
7ed6e52
Compare
aliXsed
changed the title
* Implement Fixed trait. * Fix tests * Fix tests * Fix tests 2 * Address review comment regarding from_i129. * Remove precision by using log10() as suggested in review. * Add small comments. * Use checked versions + panic for ops::*. * Remove repeated test. * Uncomment test. * Remove casts. * Add more comments. * Add tests. * Panic on saturating_div_int * More tests. * More docs. * Saturating renames. * Fix to_bound doc. * Move some impl to trait. * Add range * Add macro pre. * More round() tests. * Delete confusion. * More impl to trait * Add doc for fixedpoint op. * Remove trailing spaces. * Suggested docs changes. * More tests and comments for roundings. * Some quickcheck tests. * Add missing panic, more test/comments. * Nits. * Rename. * Remove primitives-types import. * Apply review suggestions * Fix long lines and add some fuzz. * fix long line * Update fuzzer * Bump impl * fix warnings Co-authored-by: Gavin Wood <gavin@parity.io> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Commit: c5280a6 [c5280a6] Parents: d047cb3 Author: Marcio Diaz <marcio.diaz@gmail.com> Date: 22 May 2020 at 5:32:44 AM NZST Committer: AlexSedNZ <alex.sedighi@centrality.ai> Commit Date: 29 September 2020 at 2:12:51 PM NZDT Labels: origin/fix/141-weight-multiplier GPG Details: [GOOD] Alex Sedighi
aliXsed
force-pushed
the
fix/141-weight-multiplier
branch
from
fea404e
to
9cbb277
Compare
jordy25519
approved these changes
Oct 1, 2020
| @@ -202,7 +202,7 @@ fn transaction_fee_is_correct_ultimate() { | |||
| fn block_weight_capacity_report() { | |||
| // Just report how many transfer calls you could fit into a block. The number should at least | |||
| // be a few hundred (250 at the time of writing but can change over time). Runs until panic. | |||
| use node_primitives::Index; | |||
| use node_primitives::{Index, Hash}; | |||
There was a problem hiding this comment.
(nit) wondering why this change?
KarishmaBothara
approved these changes
Oct 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring in paritytech/substrate#5877 and paritytech/substrate#6214 as preparational steps for #141:
Co-authored-by: Gavin Wood gavin@parity.io
Co-authored-by: Shawn Tabrizi shawntabrizi@gmail.com