Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build system requirements #355

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Update build system requirements #355

merged 1 commit into from
Jul 18, 2023

Conversation

cdce8p
Copy link
Contributor

@cdce8p cdce8p commented Jul 18, 2023

To build packages for Python 3.12 it's necessary to update setuptools to at least >=66.1.0.

https://setuptools.pypa.io/en/latest/history.html#v68-0-0
https://wheel.readthedocs.io/en/stable/news.html

@cdce8p cdce8p requested a review from a team as a code owner July 18, 2023 13:40
@CoMPaTech CoMPaTech added enhancement New feature or request dependencies Pull requests that update a dependency file labels Jul 18, 2023
CoMPaTech
CoMPaTech approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your PR!

@bouwew
Copy link
Contributor

bouwew commented Jul 18, 2023

@cdce8p Sure, but we have not added python v3.12 anywhere in the github configuration files.
So this PR seems pointless to me without additional changes?

@cdce8p
Copy link
Contributor Author

cdce8p commented Jul 18, 2023

So this PR seems pointless to me without additional changes?

Not pointless. I've started testing Home Assistant with Python 3.12 but at the moment this causes a build failure, so I don't actually get to run the tests.

The classifier for Python 3.12 can always be added later once it's fully tested.

bouwew
bouwew approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@bouwew bouwew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this context, LGTM too.

Please note, we still have to make a new release.
Also, it might be a while before this new released version becomes linked in HA Core Plugwise.

@bouwew bouwew merged commit 0804cf9 into plugwise:main Jul 18, 2023
1 check passed
@cdce8p cdce8p deleted the update-build-system branch July 18, 2023 19:50
@cdce8p
Copy link
Contributor Author

cdce8p commented Jul 18, 2023 •
edited
Loading

Please note, we still have to make a new release.

Just saw that you created 31.0.6. Unfortunately it seems the release wasn't uploaded to PyPI. Maybe because the version in pyproject.toml wasn't updated?
https://github.com/plugwise/python-plugwise/actions/runs/5591098044/jobs/10221708639#step:6:27

Also, it might be a while before this new released version becomes linked in HA Core Plugwise.

Sure, but we've to start someday 🙂 The earlier the fix is included in a release, the earlier it will be used by HA.

@bouwew
Copy link
Contributor

bouwew commented Jul 19, 2023

@cdce8p v0.31.7 is available on pypi now.

@cdce8p cdce8p mentioned this pull request Jul 19, 2023
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoMPaTech CoMPaTech CoMPaTech approved these changes

@bouwew bouwew bouwew approved these changes

Assignees

@CoMPaTech CoMPaTech

@bouwew bouwew

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdce8p @bouwew @CoMPaTech