Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable Python tests (short+medium) to be run on PMem #5648

Merged
merged 1 commit into from
May 18, 2023

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented May 16, 2023

Enable Python tests (short+medium) to be run on PMem

Requires:

Fixes: #5649
Signed-off-by: Tomasz Gromadzki tomasz.gromadzki@intel.com


This change is Reviewable

@grom72 grom72 added this to the 1.13 on GHA milestone May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #5648 (174336d) into stable-1.13 (850a099) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           stable-1.13    #5648      +/-   ##
===============================================
- Coverage        74.27%   74.26%   -0.01%     
===============================================
  Files              145      145              
  Lines            22131    22131              
  Branches          3705     3704       -1     
===============================================
- Hits             16438    16436       -2     
- Misses            5693     5695       +2     

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)


.github/workflows/unittest.yml line 36 at r1 (raw file):

        run: make check

      - name: Run tests (Python)

This split between Bash and Python tests is very unfortunate.

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukaszstolarczuk)

@grom72 grom72 removed the request for review from lukaszstolarczuk May 16, 2023 11:25
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 force-pushed the test-fix-enable-python-check branch from f9b6641 to 174336d Compare May 18, 2023 04:34
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@grom72 grom72 merged commit 9c975da into pmem:stable-1.13 May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants