Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable obj_sync/TEST[2,5-6] for all configurations until #5646 is fixed #5704

Merged
merged 1 commit into from
May 31, 2023

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented May 30, 2023

Disable tests until the issue #5646 is fixed.

Fixes: #5700.


This change is Reviewable

@grom72 grom72 added this to the 1.13 on GHA milestone May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #5704 (0723115) into stable-1.13 (9e87547) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 0723115 differs from pull request most recent head b0c2916. Consider uploading reports for the commit b0c2916 to get more accurate results

@@               Coverage Diff               @@
##           stable-1.13    #5704      +/-   ##
===============================================
- Coverage        74.30%   74.28%   -0.02%     
===============================================
  Files              145      145              
  Lines            22133    22134       +1     
  Branches          3705     3706       +1     
===============================================
- Hits             16446    16443       -3     
- Misses            5687     5691       +4     

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@grom72 grom72 mentioned this pull request May 30, 2023
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @grom72)


src/test/obj_sync/DISABLE_TEST2 line 11 at r1 (raw file):

by adding the prefix DISABLE_ to the script name.


src/test/obj_sync/DISABLE_TEST5 line 11 at r1 (raw file):

# XXX disable the test for 'drd'
# until https://github.com/pmem/pmdk/issues/5646 is fixed
# by addind a prefix DISABLE_ to script name

.


src/test/obj_sync/DISABLE_TEST6 line 11 at r1 (raw file):

# XXX disable the test for 'helgrind'
# until https://github.com/pmem/pmdk/issues/5646 is fixed
# by addind a prefix DISABLE_ to script name.

.

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @grom72)

@osalyk osalyk added the sprint goal This pull request is part of the ongoing sprint label May 31, 2023
Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)


src/test/obj_sync/DISABLE_TEST2 line 11 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

by adding the prefix DISABLE_ to the script name.

Done.


src/test/obj_sync/DISABLE_TEST5 line 11 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

.

Done.


src/test/obj_sync/DISABLE_TEST6 line 11 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

.

Done.

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r2, all commit messages.
Reviewable status: 1 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r2.
Reviewable status: 2 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi and @osalyk)

Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @janekmi)

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @grom72)


src/test/obj_sync/DISABLE_TEST2 line 11 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Done.

adding


src/test/obj_sync/DISABLE_TEST5 line 11 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Done.

.


src/test/obj_sync/DISABLE_TEST6 line 11 at r1 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Done.

.

Disable tests until the issue pmem#5646 is fixed.

Fixes: pmem#5700.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 3 files reviewed, 3 unresolved discussions (waiting on @janekmi)


src/test/obj_sync/DISABLE_TEST2 line 11 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

adding

Done.


src/test/obj_sync/DISABLE_TEST5 line 11 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

.

Done.


src/test/obj_sync/DISABLE_TEST6 line 11 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

.

Done.

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@janekmi janekmi merged commit 1a5ca6e into pmem:stable-1.13 May 31, 2023
@grom72 grom72 deleted the test-fix-5700 branch June 6, 2023 06:56
@grom72 grom72 restored the test-fix-5700 branch June 6, 2023 06:56
@grom72 grom72 deleted the test-fix-5700 branch June 6, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants