Further cleanup of the fabric and topology support #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjhursey
previously approved these changes
Sep 24, 2020
|
@jjhursey Worth taking another look at - I updated the compute_distance support to handle multiple device types (e.g., GPU) and not just fabric. |
jjhursey
reviewed
Sep 29, 2020
Rename PMIx_Fabric_update_distances to PMIx_Fabric_compute_distances and provide parameters to support computing of distances for given topologies. This allows support for hetero situations. Change PMIx_Get_cpuset so it actually returns the bitmap of the current process or thread, as specified. Add PMIx_Parse_cpuset_string to convert a string to an actual bitmap. Cleanup the distance computation APIs Distances can be computed for many device types, not just fabric, so rename the API accordingly and move it to the process locality area since it is locality-related. Define a data type by which the caller can specify the type(s) of device(s) they want distances to, along with the topology and cpuset to use. Signed-off-by: Ralph Castain <rhc@pmix.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename PMIx_Fabric_update_distances to PMIx_Fabric_compute_distances and
provide parameters to support computing of distances for given
topologies. This allows support for hetero situations.
Change PMIx_Get_cpuset so it actually returns the bitmap of the current
process or thread, as specified.
Add PMIx_Parse_cpuset_string to convert a string to an actual bitmap.
Signed-off-by: Ralph Castain rhc@pmix.org