Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provisional markers to storage chapter #345

Merged
merged 2 commits into from
Mar 17, 2021

Conversation

jjhursey
Copy link
Member

No description provided.

Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
@jjhursey jjhursey added the WorkInProgress Work In Progress label Mar 15, 2021
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
@jjhursey jjhursey added Editorial and removed WorkInProgress Work In Progress labels Mar 15, 2021
@jjhursey jjhursey marked this pull request as ready for review March 15, 2021 19:55
@jjhursey jjhursey requested review from a team March 15, 2021 19:55
@jjhursey
Copy link
Member Author

@shanedsnyder This PR adds the provisional markers for the storage chapter and adds a section to the revisions appendix for the new items. Can you take a look and give it a 👍 if it looks good to you?

I'm aware of a slight glitch in the provisional markers on page 3 of the storage chapter (pdf page 453) where the provisional marker in the margin does not appear for PMIX_STORAGE_PERSISTENCE_ARCHIVE and pmix_storage_access_type_t. That's nothing to hold up this PR. I'll see if I can figure out what's going on there out-of-band.

Once this is merged then I'll PR #280 and this to the v4.x branch.

@jjhursey
Copy link
Member Author

@shanedsnyder Have you had a chance to take a look at this change to the Storage chapter? Any objection to merging this?

@shanedsnyder
Copy link
Contributor

Sorry, I've been out of the office the last couple of days, but just had a look. Looks good to me, thanks!

@jjhursey
Copy link
Member Author

Thanks! I'll merge and cherry-pick the storage changes to v4.0.x branch

@jjhursey jjhursey merged commit 6a63c13 into pmix:master Mar 17, 2021
@jjhursey jjhursey deleted the prov-marker-storage branch March 17, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants