Issue 175: Sharing basics -rebased on master #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be squashed eventually but doing this strange ordering in multiple commits to make sure that we can most easily see what changed. Signed-off-by: dsolt@us.ibm.com
The chapter on NonReserved_Keys is going away. The final location is a new chapter called SharingBasics that goes over the basics of how applications share data. We then present the idea that there is some "already shared data" in the form of reserved keys in that chapter. This can all get collapsed into a simpler commit when we merge, but doing it this way helps with viewing how text changed. Signed-off-by: dsolt@us.ibm.com
The final move to its new location happens in another PR The removal of Synchronization material happens in another PR The removal of the Query material happens in another PR This PR reworks the material of Chap_API_NonReserved_Keys and the PMIx_Get API presentation into a new consolidated presentation that gives a full overview of how to put/get data using PMIx and leaves the reserved keys entirely for its own chapter. Signed-off-by: dsolt@us.ibm.com
Signed-off-by: dsolt@us.ibm.com
Missing the use of refapi and ac/acp macros Some minor text changes. Signed-off-by: dsolt@us.ibm.com
Account for bad merges which missed them. Signed-off-by: dsolt@us.ibm.com
|
This PR is #393 but updated to match the current state of Dave and I decided to create a new PR instead of rebasing the old PR because of the size of the changes. This will allow us to more easily view the changes side-by-side to make sure nothing is lost in the rebase. |
jjhursey
added
Accepted as Stable
chapter xxx -> Chapter xxx
as explained in \ref{xxx} -> as explained in Chapter \ref{xxx} (or Section \ref{xxx})
many uses of PMIx functions without using the correct \refapi macro
Get rid of extraneous text: [Reference to publish/lookup chapter].
Get rid of extraneous ')' character
Signed-off-by: dsolt@us.ibm.com
Co-authored-by: Josh Hursey <4259120+jjhursey@users.noreply.github.com>
(cherry picked from commit e9fbf83)
|
I just pushed on the missing commit (e9fbf83) |
jjhursey
approved these changes
May 26, 2022
This was referenced May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of pr#393. This is the one we actually want to merge, but we need to make sure it is applying the same changes as 393.