Persist documentation for Map & Set add storage and retrieval of version #2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--HG-- branch : discussion-2689-persist-doc-map-and-set-missing-version
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
dai-shi
reviewed
Aug 20, 2024
| return { | ||
| state: { | ||
| ...state, | ||
| transactions: new Map(state.transactions), | ||
| }, | ||
| version |
There was a problem hiding this comment.
This makes version: undefined if version is undefined. We also need to use object spread here like setItem.
There was a problem hiding this comment.
I've pushed another commit switching this as you've suggested.
…n only when present by way of spread operator on existingValue --HG-- branch : discussion-2689-persist-doc-map-and-set-missing-version
dai-shi
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--HG--
branch : discussion-2689-persist-doc-map-and-set-missing-version
Related Bug Reports or Discussions
Fixes # Discussion 2689
Summary
Fixes getItem and setItem on the storage for the Map & Set persist example, so that respectfully those methods retrieves and sets the version when present.
Check List
pnpm run prettierfor formatting code and docs