-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install the self-contained binary version of pnpm #31
Conversation
This is a breaking change because the binary version of pnpm is only available from v6.17.1 close #18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You intend to drop support for pnpm versions without self-contained binary, correct? If that's the case, why even bother running the self-installer and install it via the npm registry at all? Why not just download the binary directly from GitHub release?
- Can you add code that check for unsupported pnpm versions before download? If user specify a pnpm version that doesn't have self-contained binary, it is more user-friendly to inform the user about it than an ambiguous 404.
- Can you update the README.md file? Some information in README.md is ought to be outdated after this PR.
- Finally, please remember to update
dist/index.js
before commit.
Amendment:
GitHub Release does not support version ranges (e.g. |
@zkochan When will you resolve my requests for change in this PR? |
I have to think about it. Not soon. |
Curious if this would be easier to move forward with if it's opt-in via an option (eg. |
I agree with @privatenumber . I will post another PR after I add the test and update the readme. |
Good job @tksst . I think adding a e.g. jobs:
build:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
os: [ubuntu-latest, windows-latest]
steps:
- name: Install pnpm
uses: pnpm/action-setup@v3.0.0
with:
# in the node 14.x env, we auto install `@pnpm/exe` instead of `pnpm`
# refer: https://pnpm.io/installation#compatibility
node-version: ${{ matrix.node-version }}
version: 8
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
cache: 'pnpm' |
That is a nice feature, but a bit complicated. |
After thinking about how to implement this feature, I gave up trying to implement it. |
This is a breaking change because the binary version of pnpm is only available from v6.17.1.
Also, it doesn't ship
pnpx
.close #18