Handle empty identity, handle error on removing of previosly deleted …

…keyring acc, correct handle of error if it is an object
poanetwork · Nov 13, 2018 · a33ba78 · a33ba78
1 parent af587d9
commit a33ba78
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js
@@ -821,7 +821,11 @@ module.exports = class MetamaskController extends EventEmitter {
     this.accountTracker.removeAccount([address])
 
     // Remove account from the keyring
-    await this.keyringController.removeAccount(address)
+    try {
+      await this.keyringController.removeAccount(address)
+    } catch (e) {
+      log.error(e)
+    }
     return address
   }
 

diff --git a/old-ui/app/components/account-dropdowns.js b/old-ui/app/components/account-dropdowns.js
@@ -27,6 +27,9 @@ class AccountDropdowns extends Component {
 
     return accountOrder.map((address, index) => {
       const identity = identities[address]
+      if (!identity) {
+        return null
+      }
       const isSelected = identity.address === selected
 
       const simpleAddress = identity.address.substring(2).toLowerCase()

diff --git a/old-ui/app/components/connect-hardware/index.js b/old-ui/app/components/connect-hardware/index.js
@@ -125,7 +125,7 @@ class ConnectHardwareForm extends Component {
         if (e === 'Window blocked') {
           this.setState({ browserSupported: false, error: null})
         } else if (e !== 'Window closed') {
-          this.setState({ error: e.toString() })
+          this.setState({ error: (e.message || e.toString()) })
         }
       })
   }
@@ -140,7 +140,7 @@ class ConnectHardwareForm extends Component {
         unlocked: false,
       })
     }).catch(e => {
-      this.setState({ error: e.toString() })
+      this.setState({ error: (e.message || e.toString()) })
     })
   }
 
@@ -154,7 +154,7 @@ class ConnectHardwareForm extends Component {
     .then(_ => {
       this.props.goHome()
     }).catch(e => {
-      this.setState({ error: e.toString() })
+      this.setState({ error: (e.message || e.toString()) })
     })
   }