(Fix) Display non-zero fiat value #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vbaranov
changed the title
dennis00010011b
approved these changes
Nov 12, 2018
patitonar
reviewed
Nov 13, 2018
patitonar
reviewed
Nov 13, 2018
patitonar
reviewed
Nov 13, 2018
var -> let Co-Authored-By: vbaranov <baranov.viktor.27@gmail.com>
var -> const Co-Authored-By: vbaranov <baranov.viktor.27@gmail.com>
…allet into display-non-zero-fiat
patitonar
approved these changes
Nov 13, 2018
fvictorio
approved these changes
Nov 14, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the problem in pending tx screen when fiat value is displayed as zero, and it can confuse users. They might think, that transaction is zero-cost.
Before this PR, fiat value always displays with 2 decimals.
countSignificantDecimals(val, len)is introduced in this PR, which returns the length of truncated significant decimals.Example of the problem:
