Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Delegate Proxy contract type (EIP-897) #251

Merged
merged 14 commits into from
Jan 28, 2019
Merged

Conversation

vbaranov
Copy link
Collaborator

This PR adds a new type Proxy to import account types list. It simplifies interaction with Delegate Proxy contracts.

The feature of this import type, that if Proxy contract and implementation, both are verified in Blockscout, combined ABI (proxy + implementation) will be automatically fetched in Nifty Wallet.

screenshot 2019-01-22 at 20 48 25

In addition, as implementation methods interfaces can be changed, users are able to change ABI without deleting an account simply clicking in account menu item Update Implementation ABI

screenshot 2019-01-22 at 21 00 37

Additionally:

  • e2e tests were divided to logical test cases into separate files for better dev experience.
  • account-dropdowns.js source code refactored (react-hypertext -> JSX)

@vbaranov vbaranov added this to the NW release 4.11.0 milestone Jan 23, 2019
@vbaranov vbaranov merged commit d5ad5f0 into develop Jan 28, 2019
@ghost ghost removed the awaiting for review label Jan 28, 2019
@vbaranov vbaranov deleted the proxy-contract branch January 28, 2019 20:38
@vbaranov vbaranov mentioned this pull request Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants